[rhoai-2.25] RHAIENG-6127: remove tf2onnx from ROCm TensorFlow images on rhoai-2.25 by jiridanek · Pull Request #2456 · red-hat-data-services/notebooks

jiridanek · 2026-07-07T20:30:04Z

Description

Backport RHAIENG-3019 / opendatahub-io#2987 to rhoai-2.25 — remove abandoned tf2onnx from ROCm TensorFlow workbench and runtime images.

Follows merged #2455 (papermill test fixes); this PR completes dependency removal.

Jira: RHAIENG-6127

Changes

Area	Change
`jupyter/rocm/tensorflow/.../pyproject.toml`	Remove `tf2onnx`; keep `protobuf==6.31.1` (tensorflow-rocm vs kfp; RHAIENG-4324)
`runtimes/rocm-tensorflow/.../pyproject.toml`	Remove `tf2onnx` + protobuf override → resolves to 5.29.6
`test_notebook.ipynb`	Remove `import tf2onnx` and `test_tf2onnx_conversion` entirely
Runtime Dockerfiles	Remove `monkey_patch_protobuf_6x.py` COPY (protobuf 5.x)
Both `pylock.toml`	Regenerated

Workbench Dockerfiles still copy monkey_patch_protobuf_6x.py (needed for protobuf 6.31.1 + tensorflow-rocm).

How Has This Been Tested?

rocm-jupyter-tensorflow-ubi9-python-3.12 Build Notebooks matrix job
rocm-runtime-tensorflow-ubi9-python-3.12 build

Self checklist (all need to be checked):

Ensure that you have run make test (gmake on macOS) before asking for review
Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

Made with Cursor

Summary by CodeRabbit

Changes
- Removed TensorFlow-to-ONNX conversion support and its associated package.
- Updated the bundled protobuf version.
- Removed legacy protobuf customization from the container setup.
- Refreshed package metadata and locked artifacts to match the updated runtime configuration.
Tests
- Removed the skipped TensorFlow-to-ONNX conversion test.

openshift-ci · 2026-07-07T20:30:11Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jesuino for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-07-07T20:30:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b812333b-41a0-4892-8501-0eeb7c1acf5a

📥 Commits

Reviewing files that changed from the base of the PR and between f5f399f and 9205e2e.

📒 Files selected for processing (7)

jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml
jupyter/rocm/tensorflow/ubi9-python-3.12/pyproject.toml
jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb
runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocm
runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm
runtimes/rocm-tensorflow/ubi9-python-3.12/pylock.toml
runtimes/rocm-tensorflow/ubi9-python-3.12/pyproject.toml

💤 Files with no reviewable changes (5)

runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocm
jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml
runtimes/rocm-tensorflow/ubi9-python-3.12/pyproject.toml
runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm
jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb

🚧 Files skipped from review as they are similar to previous changes (2)

jupyter/rocm/tensorflow/ubi9-python-3.12/pyproject.toml
runtimes/rocm-tensorflow/ubi9-python-3.12/pylock.toml

📝 Walkthrough

Walkthrough

The ROCm TensorFlow Python 3.12 configurations remove tf2onnx, update the runtime protobuf lock to 5.29.6, remove protobuf customization files from the images, and delete the related notebook conversion test.

Changes

ROCm TensorFlow dependency cleanup

Layer / File(s)	Summary
Dependency, lockfile, and notebook test alignment `jupyter/rocm/tensorflow/ubi9-python-3.12/pyproject.toml`, `jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml`, `jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb`, `runtimes/rocm-tensorflow/ubi9-python-3.12/pyproject.toml`, `runtimes/rocm-tensorflow/ubi9-python-3.12/pylock.toml`	Removes the `tf2onnx` dependencies, lock entries, import, and conversion test. The runtime lock changes `protobuf` from `6.31.1` to `5.29.6`.
Runtime image cleanup `runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocm`, `runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm`	Removes the Dockerfile steps that copy `usercustomize.pth` and `monkey_patch_protobuf_6x.py` into site-packages.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

red-hat-data-services/notebooks#2654: Both PRs modify ROCm TensorFlow Python 3.12 lockfiles.

Suggested reviewers: atheo89, dibryant, daniellutz

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the removal of tf2onnx from ROCm TensorFlow images and the target rhoai-2.25 branch.
Description check	✅ Passed	The description includes the required sections, detailed file changes, testing instructions, and checklist status; incomplete testing is explicitly identified.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/remove-tf2onnx-rocm-tf-rhoai-2.25

_{Comment @coderabbitai help to get the list of available commands.}

jiridanek · 2026-08-03T08:43:22Z

/build-konflux

github-actions · 2026-08-03T08:43:51Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30798495172

CI status [antigravity]

Run: Build Notebooks (push) #30798492352 — 2/2 complete · 2 skipped
Last updated: 2026-08-03T08:43:46Z

Workflow completed with skipped jobs.

jiridanek · 2026-08-03T08:44:26Z

Done. Summary:

Rebase

Rebased fix/remove-tf2onnx-rocm-tf-rhoai-2.25 onto current rhoai-2.25 and resolved conflicts in:

jupyter/rocm/tensorflow/ubi9-python-3.12/pyproject.toml
runtimes/rocm-tensorflow/ubi9-python-3.12/pyproject.toml
both pylock.toml files (regenerated via pylocks_generator.py)

Conflict resolution kept rhoai-2.25 CVE pins (cryptography>=46.0.7, keras>=3.14.0) while applying the tf2onnx removal and updated protobuf comment on the workbench.

Force-push

Pushed to rhds/fix/remove-tf2onnx-rocm-tf-rhoai-2.25:

bd8ad7b → 6c93482c

Konflux trigger

Posted /build-konflux on #2456.

The rebased commit is much smaller now (7 files, +8/−44) because lockfiles were regenerated cleanly against the current base instead of carrying the old broad upgrades.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml`:
- Line 2: Update the pylock regeneration command comment to include an explicit
override input for the project’s protobuf override, using the existing override
file or configuration that enforces protobuf==6.31.1. Ensure regenerated
dependencies retain protobuf version 6.31.1.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 62fbabb4-87db-4c72-978c-fef692466b16

📥 Commits

Reviewing files that changed from the base of the PR and between 763378f and 6c93482.

📒 Files selected for processing (7)

jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml
jupyter/rocm/tensorflow/ubi9-python-3.12/pyproject.toml
jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb
runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocm
runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm
runtimes/rocm-tensorflow/ubi9-python-3.12/pylock.toml
runtimes/rocm-tensorflow/ubi9-python-3.12/pyproject.toml

💤 Files with no reviewable changes (4)

runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm
runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocm
jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb
runtimes/rocm-tensorflow/ubi9-python-3.12/pyproject.toml

jiridanek · 2026-08-03T08:52:05Z

/build-konflux

github-actions · 2026-08-03T08:52:20Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30799009588

CI status [antigravity]

Run: Build Notebooks (pr) #30798495172 — 3/3 complete · 1 passed · 2 cancelled
Last updated: 2026-08-03T08:52:11Z after workflow update completed

Failures so far

Job	Failed step	Link
rocm-runtime-tensorflow-ubi9-python-3.12 · linux/amd64 [rhoai] / build	Run actions/checkout@`3d3c42e`	logs
rocm-jupyter-tensorflow-ubi9-python-3.12 · linux/amd64 [rhoai] / build	Run actions/checkout@`3d3c42e`	logs

Likely root causes

The workflow runs (rocm-runtime-tensorflow-ubi9-python-3.12 · linux/amd64 [rhoai] / build and rocm-jupyter-tensorflow-ubi9-python-3.12 · linux/amd64 [rhoai] / build) were cancelled during the actions/checkout step while fetching submodules (specifically cloning codeserver/ubi9-python-3.12/prefetch-input/code-server/lib/vscode).
There is no code or dependency failure in the pull request changes; the build jobs were explicitly cancelled or interrupted during checkout.

Suggested next steps

Re-run the cancelled workflow jobs to complete the build.

jiridanek · 2026-08-03T09:08:19Z

/test odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request

openshift-ci · 2026-08-03T09:08:22Z

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/test odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jiridanek · 2026-08-03T09:08:36Z

/retest odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request

openshift-ci · 2026-08-03T09:08:39Z

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/retest odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

github-actions · 2026-08-03T09:18:53Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30800968193

CI status [antigravity]

Run: Build Notebooks (pr) #30799009588 — 3/3 passed
Last updated: 2026-08-03T09:18:48Z

All matrix jobs completed successfully.

github-actions · 2026-08-03T09:19:51Z

📋 Review Summary

This pull request correctly backports the removal of the abandoned tf2onnx package from the ROCm TensorFlow workbench and runtime images for rhoai-2.25. The dependency updates, lock files, Dockerfiles, and test notebook cleanups are consistent and complete.

🔍 General Feedback

The changes successfully decouple tf2onnx from the ROCm TensorFlow stack, resolving build conflicts and ensuring clean package metadata sync across pyproject.toml and pylock.toml.

I did not post any inline review comments as no real issues or concrete improvements were found in the changed files.

Backport RHAIENG-3019 / opendatahub-io#2987 to rhoai-2.25: - Drop tf2onnx from jupyter and runtime pyproject.toml - Keep jupyter protobuf override at 6.31.1 (kfp vs tensorflow-rocm; RHAIENG-4324) - Remove runtime protobuf override (resolves to 5.29.6 without kfp) - Remove tf2onnx test/import from test_notebook.ipynb (builds on #2455) - Drop runtime monkey_patch_protobuf COPY from Dockerfiles - Regenerate pylock.toml for both images Co-authored-by: Cursor <cursoragent@cursor.com>

…code Regenerate pylock.toml comment headers via ci/generate_code.sh so they match sync-python-lockfiles.sh output expected by CI (no pylocks_generator extras). Co-authored-by: Cursor <cursoragent@cursor.com>

jiridanek · 2026-08-03T09:20:25Z

/retest odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request

openshift-ci · 2026-08-03T09:20:28Z

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/retest odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jiridanek · 2026-08-03T09:20:36Z

/test odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request

openshift-ci · 2026-08-03T09:20:40Z

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/test odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jiridanek · 2026-08-03T09:20:52Z

/build-konflux

github-actions · 2026-08-03T09:21:06Z

Superseded by newer run: https://github.com/red-hat-data-services/notebooks/actions/runs/30800970549

CI status [antigravity]

Run: Build Notebooks (push) #30800968193 — 2/2 complete · 2 skipped
Last updated: 2026-08-03T09:21:01Z

Workflow completed with skipped jobs.

github-actions · 2026-08-03T09:23:10Z

CI status [antigravity]

Run: Build Notebooks (pr) #30800970549 — 3/3 passed
Last updated: 2026-08-03T13:00:14Z

All matrix jobs completed successfully.

jiridanek · 2026-08-03T12:41:53Z

/test odh-pipeline-runtime-tensorflow-rocm-py312-on-pull-request

openshift-ci · 2026-08-03T12:41:56Z

@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25

Details

In response to this:

/test odh-pipeline-runtime-tensorflow-rocm-py312-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-08-06T09:47:56Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot requested review from atheo89 and dibryant July 7, 2026 20:30

github-actions Bot added the review-requested label Jul 7, 2026

jiridanek mentioned this pull request Jul 7, 2026

[rhoai-2.25] fix check-generated-code: linux platform for pylock generation #2457

Closed

3 tasks

ide-developer mentioned this pull request Jul 7, 2026

[rhoai-2.25] Evaluate upgrading uv (currently pinned to 0.8.12) #2458

Closed

5 tasks

openshift-ci Bot added the needs-rebase label Jul 9, 2026

jiridanek changed the title ~~RHAIENG-6127: remove tf2onnx from ROCm TensorFlow images on rhoai-2.25~~ [rhoai-2.25] RHAIENG-6127: remove tf2onnx from ROCm TensorFlow images on rhoai-2.25 Jul 9, 2026

jiridanek force-pushed the fix/remove-tf2onnx-rocm-tf-rhoai-2.25 branch from bd8ad7b to 6c93482 Compare August 3, 2026 08:43

openshift-ci Bot removed the needs-rebase label Aug 3, 2026

coderabbitai Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml Outdated

jiridanek mentioned this pull request Aug 3, 2026

[rhoai-2.25] chore(.tekton/): remove ODH leftover RStudio push PipelineRuns #2693

Merged

3 tasks

jiridanek and others added 2 commits August 3, 2026 11:20

RHAIENG-6127: fix ROCm TensorFlow pylock headers for check-generated-…

9205e2e

…code Regenerate pylock.toml comment headers via ci/generate_code.sh so they match sync-python-lockfiles.sh output expected by CI (no pylocks_generator extras). Co-authored-by: Cursor <cursoragent@cursor.com>

jiridanek force-pushed the fix/remove-tf2onnx-rocm-tf-rhoai-2.25 branch from f5f399f to 9205e2e Compare August 3, 2026 09:20

openshift-ci Bot added the needs-rebase label Aug 6, 2026

coderabbitai Bot mentioned this pull request Aug 10, 2026

[rhoai-3.5] RHAIENG-6791,6793,6814,6815,6820: chore(deps): bump PyPI CVE floors for 3.5.1 #2726

Open

3 tasks

Uh oh!

Conversation

jiridanek commented Jul 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

How Has This Been Tested?

Merge criteria:

Summary by CodeRabbit

Uh oh!

openshift-ci Bot commented Jul 7, 2026

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

jiridanek commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Uh oh!

jiridanek commented Aug 3, 2026

Rebase

Force-push

Konflux trigger

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jiridanek commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Failures so far

Likely root causes

Suggested next steps

Uh oh!

jiridanek commented Aug 3, 2026

Uh oh!

openshift-ci Bot commented Aug 3, 2026

Uh oh!

jiridanek commented Aug 3, 2026

Uh oh!

openshift-ci Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Review Summary

🔍 General Feedback

Uh oh!

jiridanek commented Aug 3, 2026

Uh oh!

openshift-ci Bot commented Aug 3, 2026

Uh oh!

jiridanek commented Aug 3, 2026

Uh oh!

openshift-ci Bot commented Aug 3, 2026

Uh oh!

jiridanek commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Uh oh!

github-actions Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI status [antigravity]

Uh oh!

jiridanek commented Aug 3, 2026

Uh oh!

openshift-ci Bot commented Aug 3, 2026

Uh oh!

jiridanek commented Jul 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading

github-actions Bot commented Aug 3, 2026 •

edited

Loading